Re: ROM Dump of Amiga Keyboard controller

From: Kajtár Zsolt <soci_at_c64.rulez.org>
Date: Sun, 06 Jul 2014 17:51:36 +0100
Message-ID: <53B97E98.3050702@c64.rulez.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> I've made sources for both versions for easy comparison what was
>> changed: http://singularcrew.hu/temp/1520-01.asm 
>> http://singularcrew.hu/temp/1520-03.asm
> The font layout in the old listing seemed better to me, as it showed how
> the numbers were calculated.
>> 
>> There were some IEC bugs (timing and responding to channels >=8), pen
>> didn't move far enough on change request and the steppers were not that
>> fast as expected. Rest seems to be optimizations.
>> 
> I did a diff, but more context would be of interest.
> 
> Also, it looks like line 968  (#65) and 990 (#35) are constants that can
> be put at the top of the file, as are 889/903 time delay amounts (in the
> -03 ROM).

I've replaced magic numbers with constants and calculations now.

> line 835/837 is interesting.  Wonder what is going on there.

In theory it tries to avoid drawing outside of the canvas by lifting up the pen.

> lin 427 says unused, but the same line is in the -01 ROM.  Is it unused
> in both?

It's not used in -03, as the same function is done elsewhere. They've left
it in by mistake.

> Was the lack of storing cmd_x to >512 just an optimization?  How do they
> know it is 0 already?

It's an optimization. It does not have to be exact, just big enough to move
the head to the change position.

> Line 283 (#67) looks like another constant.

There are plenty of constants now for adjusting various things.

http://singularcrew.hu/temp/1520-01.asm.html
http://singularcrew.hu/temp/1520-03.asm.html

The normal asm/dasm files are on the place as before. But not for too long
as the temp directory is cleaned up periodically... Any chance to get this
to zimmers ftp?

- -- 
						    -soci-
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlO5fpEACgkQyBOVYiJltRbfzACgrr759r9UlVH/rkpg+VVJJpo3
Y+8An0jFbRwFZAyp2o0n9O8Q+U/HMo2X
=iz5V
-----END PGP SIGNATURE-----

       Message was sent through the cbm-hackers mailing list
Received on 2014-07-06 17:00:02

Archive generated by hypermail 2.2.0.